Add filters to wp_new_user_notification and wp_password_change_notification

[pbearne]

There is a filters (retrieve_password_title and retrieve_password_message) to set retrieve password message in wp-login but not for wp_new_user_notification and wp_password_change_notification in pluggable.php this patch adds them

the new filters are
wp_password_change_notification_subject
wp_password_change_notification_message
wp_password_change_notification_headers

wp_new_user_notification_admin_message
wp_new_user_notification_admin_subject
wp_new_user_notification_admin_headers

wp_new_user_notification_message
wp_new_user_notification_subject
wp_new_user_notification_headers

[pbearne]

patch

[kraftbj]

Howdy! Thanks for the patch. It's easier for folks to apply/test patches if they are created from the svn root, so the full path (e.g. src/wp-includes/pluggable.php etc) is part of the patch.

I like this—makes it easier to customize these without having to totally duplicate the functions.

That said, being in pluggable.php, these functions can be wholly overwritten by plugins, making the filters unavailable. I don't see this done in other filters in pluggable.php, but would it makes sense to denote that in the inline documentation?

[pbearne]

For an example look at wp_notify_moderator() I copied the headers filter to match

I have been working on WP VIP project so can only ship a theme where the client wanted to change the eamil content but I can't replace the pluggable function in a theme as the file sis load before the theme

Yes there will be plugin/code that overloads the function that will not have the filters but any new one and updates can have them. The filter not not been there is not a reason to not add them

will fix patch root I thought is was the dev root

[pbearne]

added comment that these filter might be missing due to function pluggable

[johnbillion]

@pbearne Could you check the $message_headers functionality in your patch please? Looks like at least one occurrence isn't used in wp_mail().

[pbearne]

fixed wp_mail call that was missing $mesage_header parm

[pbearne]

Thanks for the spot @johnbillion found and fixed

[pbearne]

@johnbillion are you able to get this into 4.7?

[dipesh.kakadiya]

User date added as message filter argument for updated password

[dipesh.kakadiya]

Filter argument updated

[jtsternberg]

Just ran into this. Seems super odd that these filters aren't already in core. Is there anything we can do to get these in 4.7?

[pbearne]

@jtsternberg ping them on slack in the core channel now would a good time as they doing a meeting where this is decided :-)

[johnbillion]

In 41153:

Users: Introduce filters for the contents of email notifications for new user registrations and password resets.

Introduces:

• wp_password_change_notification_subject
• wp_password_change_notification_message
• wp_password_change_notification_headers
• wp_new_user_notification_admin_subject
• wp_new_user_notification_admin_message
• wp_new_user_notification_admin_headers
• wp_new_user_notification_subject
• wp_new_user_notification_message
• wp_new_user_notification_headers

Props pbearne, dipesh.kakadiya

Fixes #38068

[johnbillion]

It looks like all of the most recently introduced email notifications use one filter on an array of fields for the email (eg. email_change_email and password_change_email) instead of separate filters for the subject, content, and headers. This pattern should be followed here.

[pbearne]

Hi @johnbillion

I will recreate the patch ASP

Paul

[pbearne]

patch using array format

[pbearne]

Here you go one patch using an array to pass the values

I noted that the wp_mail for the wp_new_user_notification_email_admin has an @errror prexit I wonder if we can remove it?

paul

[johnbillion]

38068.2.patch​ corrects some errors in 38068.patch​ and makes some further tweaks. This is good to go.

[johnbillion]

In 41213:

Users: Switch to using array style filters for the newly introduced filters in wp_password_change_notification() and wp_new_user_notification().

This introduces three new filters, replacing those that were introduced in [41153]:

• wp_password_change_notification_email
• wp_new_user_notification_email_admin
• wp_new_user_notification_email

Props pbearne

Fixes #38068