#38085 closed defect (bug) (fixed)
Add a 'View' link to users listed on the Users screen
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Users | Keywords: | good-first-bug has-patch |
Focuses: | administration | Cc: |
Description
On the listing screens for posts, pages, categories, tags, media, etc, there's a 'View' link for each item. Not so for the Users screen.
The 'View' link should point to the user's author archive using get_author_posts_url()
.
Related: #20307
Attachments (5)
Change History (20)
#3
@
7 years ago
Talking it over at said contributor day and there's already work in progress on this one.
#5
@
7 years ago
- Owner changed from ryanplasma to ryanplas
Helping ryanplas assigning to avoid conflict
@
7 years ago
Whitespace, and skip if get_author_posts_url()
returns an empty result (thanks to a mutable filter at the end)
#7
@
6 years ago
I have made changes on existing .path to improve coding standard.
Solve phpcs notice:
- Expected 1 space before/after closing bracket [ ( 'View' ) ]
- Line indented incorrectly
Also, Updated user view URL, I thought that we don't need to add add_query_arg( 'wp_http_referer', urlencode( wp_unslash( $_SERVER['REQUEST_URI'] ) )
while creating URL. So, I have removed it.
Thank you
This ticket was mentioned in Slack in #core by viralsampat. View the logs.
6 years ago
#9
@
6 years ago
@Girishpanchal Thanks for your patch!
In other list tables, an aria-label
attribute is used for this link. See https://github.com/WordPress/wordpress-develop/blob/bb6e34a7fd236f1b88bc2ccf3b0d91a557368e45/src/wp-admin/includes/class-wp-terms-list-table.php#L462-L467 for an example.
Here we should add such an attribute as well for improved accessibility. You should also use sprintf()
to make the code more readable.
#10
@
6 years ago
Patch: 38085.5.diff
Updated: @Girishpanchal patch with sprintf & made use of an aria label as of 'View user %s' per @swissspidy suggestion.
Best regards,
Konstantinos
Checking in from contributor day, happy to take a look at this one.