WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 days ago

Last modified 3 days ago

#38088 closed enhancement (fixed)

JavaScript detection missing on wp-login

Reported by: Nikschavan Owned by: desrosj
Milestone: 5.3 Priority: normal
Severity: normal Version: 4.7
Component: Login and Registration Keywords: has-patch commit
Focuses: javascript Cc:

Description

WordPress admin adds class no-js to body if JavaScript is disabled, but this class is disabled on wp-login.php

It is required when handling UI changes when JS is disabled.

related #33167

Attachments (1)

38088.diff (589 bytes) - added by Nikschavan 3 years ago.

Download all attachments as: .zip

Change History (8)

@Nikschavan
3 years ago

#1 @Nikschavan
3 years ago

  • Component changed from General to Login and Registration
  • Focuses javascript added
  • Keywords has-patch added

#2 @Nikschavan
3 years ago

  • Type changed from defect (bug) to enhancement

#3 @desrosj
6 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 5.3

Thanks for this, @Nikschavan! I am moving to 5.3 for testing and review.

#4 @desrosj
4 days ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#5 @desrosj
3 days ago

  • Keywords commit added; needs-testing removed

#6 @desrosj
3 days ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46192:

Login and Registration: Detect JavaScript on the login screen.

This allows the login screen to be targeted with CSS when JavaScript is disabled.

Props Nikschavan.
Fixes #38088.

#7 @afercia
3 days ago

Just a note that this change was already included in the proposed patch on #42888 :)

Note: See TracTickets for help on using tickets.