WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#38089 closed defect (bug) (fixed)

Erroneous comment in WP_Upgrader::create_lock()

Reported by: markshep Owned by: SergeyBiryukov
Priority: normal Milestone: 4.7
Component: Upgrade/Install Version: 4.7
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

The comment regarding an existing lock still being valid is inverted regarding when the code bails. Please see attached diff for a correction.

Attachments (1)

0001-Fixed-comment-regarding-existing-lock.patch​ (824 bytes ) - added by markshep 10 years ago.

Download all attachments as: .zip

Change History (3)

@markshep
10 years ago

#1 @SergeyBiryukov
10 years ago

  • Keywords has-patch added
  • Milestone Awaiting Review → 4.7

Hi @markshep, welcome to Trac! Thanks for the patch.

Introduced in [36821].

#2 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 38622:

Docs: Correct a comment and @return entry in WP_Upgrader::create_lock().

Props markshep.
Fixes #38089.

Note: See TracTickets for help on using tickets.