WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 7 months ago

#38089 closed defect (bug) (fixed)

Erroneous comment in WP_Upgrader::create_lock()

Reported by: markshep Owned by: SergeyBiryukov
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:

Description

The comment regarding an existing lock still being valid is inverted regarding when the code bails. Please see attached diff for a correction.

Attachments (1)

0001-Fixed-comment-regarding-existing-lock.patch (824 bytes) - added by markshep 7 months ago.

Download all attachments as: .zip

Change History (3)

#1 @SergeyBiryukov
7 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.7

Hi @markshep, welcome to Trac! Thanks for the patch.

Introduced in [36821].

#2 @SergeyBiryukov
7 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 38622:

Docs: Correct a comment and @return entry in WP_Upgrader::create_lock().

Props markshep.
Fixes #38089.

Note: See TracTickets for help on using tickets.