Wrong quotation mark after bracket

[josepo]

formatting.php sets a closing quotation mark after a bracket, even at the beginning of words. Example:

A dog ("Hubertus") was sent out.

The first quotation mark will not be formatted properly. This looks especially ugly when using the intypo plugin.

Solution: In formatting.php, replace the line

$dynamic_characters = array('/\'(\d\d(?:’|\')?s)/', '/(\s|\A|")\'/', '/(\d+)"/', '/(\d+)\'/', '/(\S)\'([^{\'\s])/', '/(\s|\A)"(?!\s)/', '/"(\s|\S|\Z)/', '/\'([\s.]|\Z)/', '/(\d+)x(\d+)/');}

with

$dynamic_characters = array('/\'(\d\d(?:’|\')?s)/', '/(\s|\A|")\'/', '/(\d+)"/', '/(\d+)\'/', '/(\S)\'([^{\'\s])/', '/(\s|\A|\s\(|\A\()"(?!\s)/', '/"(\s|\S|\Z)/', '/\'([\s.]|\Z)/', '/(\d+)x(\d+)/');}

[josepo]

This solution is a whole lot better yet (covers all expressions where the delimiting blank does not immediately precede or follow the quotation mark):

$dynamic_characters = array('/\'(\d\d(?:’|\')?s)/', '/(\s|\A|")\'/', '/(\d+)"/', '/(\d+)\'/', '/(\S)\'([^{\'\s])/', '/(\s|\A|\s\S|\A\S)"(?!(\s|\A|\S\s|\S\A))/', '/"(\s|\S|\Z)/', '/\'([\s.]|\Z)/', '/(\d+)x(\d+)/');}

Currently,

<p>A dog named "<a href="​http://...">Hubertus</a>":</p>

results in the second quotation mark turning the wrong way. This is fixed by the solution shown above. (Of course, it also covers the bracket problem.)

[Nazgul]

Patch based on given code snippet added.

[mrmist]

refreshed against 10257

[mrmist]

I've refreshed the patch on this. Shifting to 2.8 since it has a patch and has been languishing.

It'd suggest it either goes in or is closed.

[mrmist]

See also #4539

[Denis-de-Bernardy]

Maybe wontfix, yeah. it's been open and ignored for so long... :D

Maybe someone who shows up with a full load of tests with results might convince devs to commit, though.

[azaozz]

Partial duplicate of #8775, perhaps better to merge them.

[Denis-de-Bernardy]

Let's worry about merging all of the formatting tickets after 2.8. They've been open for so long that it doesn't matter much if it gets fixed now or then.

Punting pending unit-tests.

[hakre]

+1 for merging

[westi]

Dupe of #1418.

I have added this explicit test case to wordpress-tests.

Fixed in [11813]