WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 4 years ago

#38101 closed enhancement (fixed)

Unit test for _cleanup_header_comment()

Reported by: pbearne's profile pbearne Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 5.5 Priority: normal
Severity: normal Version: 4.7
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

start of unit test for _cleanup_header_comment()

Attachments (2)

_cleanup_header_comment.php.patch​ (2.6 KB) - added by pbearne 8 years ago.
unit test
38101.diff​ (3.4 KB) - added by peterwilsoncc 4 years ago.

Download all attachments as: .zip

Change History (11)

@pbearne
8 years ago

unit test

#1 @desrosj
5 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Owner set to desrosj
  • Status changed from new to reviewing

#2 @desrosj
5 years ago

  • Owner desrosj deleted

This ticket was mentioned in ​Slack in #core by noisysocks. ​View the logs.
4 years ago

#4 @peterwilsoncc
4 years ago

  • Owner set to peterwilsoncc
  • Status changed from reviewing to accepted

#5 @whyisjake
4 years ago

Tests look good to me.

@peterwilsoncc
4 years ago

#6 @peterwilsoncc
4 years ago

In 38101.diff​ :

  • tidyup for some coding standards
  • converted to use a data provider for ease adding new tests
  • added a dockblock style comment to the tests.

This ticket was mentioned in ​PR #259 on ​WordPress/wordpress-develop by ​peterwilsoncc.
4 years ago #7

#8 @peterwilsoncc
4 years ago

  • Component changed from General to Build/Test Tools
  • Milestone changed from Future Release to 5.5

#9 @peterwilsoncc
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47779:

Tests: Add unit tests for _cleanup_header_comment().

Props pbearne.
Fixes #38101. See #8497.

Note: See TracTickets for help on using tickets.