Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38125 closed defect (bug) (fixed)

Re-enable monospaced font in tinymce's dialog window (codesample plugin)

Reported by: timhavinga's profile timhavinga Owned by: azaozz's profile azaozz
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords:
Focuses: ui Cc:


The TinyMCE-editor has a built-in dialog window. In this flexible dialog, different UI elements can be shown, as specified by their plugin. One of these UI elements is a textarea with a specific class.

In my case, I use the codesample plugin - a default plugin of TinyMCE, though not packaged with WordPress - which enables me to place pieces of preformatted code in the visual editor.
This plugin allows me to edit these code blocks via the built-in dialog, with a textarea to enter my code. To show the code in a monospaced font, the class .mce-monospace is added to the textarea.
However, the styling of this class is overridden by line 7-13 in wp-includes/css/editor.css, which specifies that the font-family should be inherited for all child elements of the modal.

I believe this should be an easy fix by either excluding the field with the class .mce-monospace from the said lines of CSS or by adding a more specific CSS rule which re-enables the monospaced font.

Change History (4)

This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.

8 years ago

#2 @iseulde
8 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Version 4.6.1 deleted

Welcome to Trac! This sounds good. Could you provide a patch? :)

#3 @azaozz
8 years ago

  • Keywords needs-patch removed
  • Milestone changed from Future Release to 4.7

#4 @azaozz
8 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 38801:

TinyMCE: restore the monospace font in textareas in the TinyMCE UI. Make it same as in the Text editor.

Fixes #38125.

Note: See TracTickets for help on using tickets.