Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38131, comment 26


Ignore:
Timestamp:
08/27/2017 01:04:26 PM (7 years ago)
Author:
adamsilverstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38131, comment 26

    initial v1  
    1 @TimothyBlynJacobs Thanks for the updated patch here, it makes sense to include the filtering code in the controller itself. The nested field support is also nice - my only concern would be about the overhead.
     1@TimothyBlynJacobs Thanks for the updated patch here, it makes sense to include the filtering code in the controller itself (using the filter made it easier to release as a plugin). The nested field support is also nice - my only concern would be about the overhead.
    22
    33In terms of limiting fields queried, there is a deeper issue here with cache hydration - the query is expected to hydrate the cache for subsequent queries (also the reason WP_QUERY only offers a few options for it's '`fields` parameter). if we only queried for some fields, we couldn't hydrate the cache fully, and subsequent (on the same page even) queries for post data would fail (or need another query).