Opened 8 years ago
Closed 8 years ago
#38152 closed defect (bug) (fixed)
Clarify in the DocBlock that get_site_by_path() does not return exact matches
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 4.7 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Networks and Sites | Keywords: | good-first-bug has-patch |
| Focuses: | docs, multisite | Cc: |
Description
Related Slack discussion: https://wordpress.slack.com/archives/core-multisite/p1474390310000390
get_site_by_path() does not return exact matches because it also searches sites with path = '/'. The same applies to WP_Network::get_by_path() but its DocBlock is much better. We should add a similar comment to get_site_by_path().
Attachments (2)
Change History (10)
#2
@
8 years ago
- Milestone changed from Future Release to 4.7
- Owner set to DrewAPicture
- Status changed from new to reviewing
This ticket was mentioned in Slack in #docs by morganestes. View the logs.
8 years ago
#5
@
8 years ago
sry., there was a diff option issue. In the previous patch, the red block should be the green block and vice versa.
I've uploaded a revised version.
This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.
8 years ago
Note: See
TracTickets for help on using
tickets.
The patch doesn't seem to match the description. Don't we want the description to be more descriptive, rather than shorter here?