WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38172, comment 8


Ignore:
Timestamp:
09/29/2016 07:39:25 PM (4 years ago)
Author:
davidakennedy
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38172, comment 8

    initial v1  
    1010> Could you add an example implementation that a theme would use? How are things like height/width enforced?
    1111
    12 Right – do you have any suggestions for how best to handle back compat?
     12Right – do you have any suggestions for how best to handle back compat? I have an experimental branch of Twenty Seventeen going for this: https://github.com/davidakennedy/twentyseventeen/tree/vheader
     13
     14And: https://github.com/davidakennedy/twentyseventeen/blob/vheader/inc/custom-header.php
     15
     16Calling the function here:
     17
     18https://github.com/davidakennedy/twentyseventeen/blob/vheader/components/header/header-image.php
    1319
    1420> In terms of feedback about the patch: We shouldn't introduce new constants for jit theme support, it's a new feature. I saw a few formatting issues but those are minor. Fleshing out the API will take a bit more work.