Regex special chars should be escaped in WP_oEmbed

[jrf]

Just noticed four oembed regexes which each contained a non-escaped dot which potentially could result in incorrect matches (not very likely).

. in a regex means "match anything", it needs to be escaped \. to be interpreted as a literal period character.

So, for example, http://daiwly/ would match when it shouldn't. Though as I said, very unlikely as that would not make for a valid url.

These are probably artifacts from when each of these were transformed from a non-regex key into a regex based key.

[jrf]

Adjust the related unit test provider array + add unit tests for the issue

[SergeyBiryukov]

In 38684:

Embeds: Escape periods in oEmbed regex.

Props jrf.
Fixes #38187.

[jrf]

Remove copy/paste artifact - unused and unnecessary variable in the test data provider method.

[jrf]

Thanks for merging.

And sorry but I just noticed there was still a copy/paste artifact in the test code. Uploaded a patch to remove it.

[jrf]

@SergeyBiryukov Just checking - did you see my last response & patch ?

[SergeyBiryukov]

Replying to jrf:

@SergeyBiryukov Just checking - did you see my last response & patch ?

Seeing it now, thanks! It's OK to reopen the ticket if there are any additional fixes to make sure they don't get missed :)

[SergeyBiryukov]

In 38714:

Unit Tests: Remove unused variable in Tests_oEmbed::dataShouldNotMatchOembedRegex().

Props jrf.
See #38187.

[jrf]

@SergeyBiryukov Thanks!

The reopen status has this ominous The resolution will be deleted note next to it which sounds as if any commits made for the ticket would be automatically reverted, so I was a bit wary about using it. Hmm.. maybe a ticket should be opened in meta about clarifying the message ?

[SergeyBiryukov]

Replying to jrf:

The reopen status has this ominous The resolution will be deleted note next to it which sounds as if any commits made for the ticket would be automatically reverted, so I was a bit wary about using it. Hmm.. maybe a ticket should be opened in meta about clarifying the message ?

Good point, never thought about that. Yeah, feel free to create a meta ticket.