WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38190 closed defect (bug) (fixed)

Minor fixes for plugin-install.php

Reported by: chriswiegman's profile ChrisWiegman Owned by: helen's profile helen
Milestone: 4.7 Priority: normal
Severity: trivial Version: 4.7
Component: General Keywords: has-patch
Focuses: administration Cc:

Description

Fixes two minor issues in wp-admin/plugin-install.php

1.) Conditionals on the tab check
2.) Duplicate if statements (no break in between)

Attachments (1)

plugin-install.diff​ (693 bytes) - added by ChrisWiegman 8 years ago.
Diff to fix minor plugin install differences.

Download all attachments as: .zip

Change History (7)

@ChrisWiegman
8 years ago

Diff to fix minor plugin install differences.

#1 @ChrisWiegman
8 years ago

  • Severity changed from normal to trivial

#2 @ChrisWiegman
8 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core by chriswiegman. ​View the logs.
8 years ago

This ticket was mentioned in ​Slack in #core by helen. ​View the logs.
8 years ago

#5 @helen
8 years ago

  • Milestone changed from Awaiting Review to 4.7

Introduced in [38172]. Worth fixing so nobody later is left wondering if there's some secret WordPressy reason there's a duplicate conditional like that.

#6 @helen
8 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 39336:

Plugin install: De-duplicate a conditional, introduced in [38172].

props ChrisWiegman.
fixes #38190.

Note: See TracTickets for help on using tickets.