WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 5 months ago

#38191 closed defect (bug) (fixed)

Further hardening of the role and capability tests

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Role/Capability Keywords:
Focuses: Cc:

Description

Followup to #32394, in particular [38521].

The role and capability tests are now split into those for primitive capabilities and those for meta capabilities. Further testing shows that some meta capabilities have been incorrectly listed as primitive, and vice versa.

Tests can be introduced to test these tests.

Change History (8)

#1 @johnbillion
6 months ago

  • Owner set to johnbillion
  • Status changed from new to accepted

#2 @johnbillion
6 months ago

  • Component changed from Users to Role/Capability

#3 @johnbillion
6 months ago

In 38696:

Role/Capability: Correct some meta capabilities that were incorrectly listed as primitive capabilities in the role and capability tests.

See #38191

#4 @johnbillion
6 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 38697:

Role/Capability: Introduce tests that assert the primitive and meta capability tests test the correct capabilities.

Fixes #38191

#5 @johnbillion
6 months ago

  • Keywords needs-patch removed

#6 @swissspidy
6 months ago

  • Milestone changed from Awaiting Review to 4.7

#7 @johnbillion
5 months ago

In 38769:

Role/Capability: Add tests for all user roles that check custom capabilities that do not have any form of handling (eg. in a map_meta_cap filter).

See #38191

#8 @johnbillion
5 months ago

In 38802:

Role/Capability: Disregard the order of capabilities when testing that single site and multisite capability tests match.

See #38191

Note: See TracTickets for help on using tickets.