Linking directly into Edit Image mode breaks cropping; imageEdit.init not triggered.

[dougwollison]

I've noticed for a while that when jumping directly into Edit Image mode on an attachment (namely when clicking the "Edit Image" link for an attachment inside the Media Manager), trying to crop the image doesn't work.

To reproduce, simply visit the edit link for any attachment with "&image-editor" tacked onto the URL. (e.g. /wp-admin/post.php?post=123&action=edit&image-editor)

When you drag to create the crop box, the Selection values keep saying NaN, and so trying to confirm your selection won't do anything, not even give you a visible error.

Currently, the only solution when when this occurs is to click cancel, then the Edit Image button on the screen there, where it properly initializes.

After some debugging in wp-admin/js/image-edit.js, I found the cause was that imageEdit.hold.sizer was undefined, which is set by imageEdit.init(). This method is called when the Edit Image button is clicked manually, but it never get's called on page load when it's triggered automatically.

Not entirely sure where the call should go, but that should be the only adjustment needed to make it work.

[jbotte]

Working on a patch, still going down the rabbit hole. Will try and post something next week.

[jbotte]

diff for image-edit.php to trigger imageEdit.init() if linking directly to the image editor.

[jbotte]

I attached a small patch above. First patch so if things aren't up to snuff I appreciate feedback to help improve.

On php page load i check for the 'image-editor' key in the $_GET array.

If the key exists I populate $image_edit_additional_js with the JS that will trigger imageEdit.init();

I then echo that js in the image-preview onload.

Let me know if you have any questions. Please test!

hope this helps you @dougwollison

[desrosj]

Thanks for all your work on this, @jbotte! Sorry that this did not receive a response sooner.

I have been working to reproduce this issue, but I have not yet been able to on WordPress 5.1.1. @jbotte or @dougwollison, are you able to provide more information to reproduce the error?

I am thinking this may have been fixed in another ticket (maybe with [42404], @adamsilverstein). Going to mark as close unless someone else can reproduce this.

[dougwollison]

Pretty sure it's been solved. The flow to recreate the issue was:

1. Open media library modal while editing a page
2. Select the image you want to edit
3. Click the Edit Image link in the sidebar

It would open the attachment editor in a new page and that's where the issue would occur. I just tested it and it appears to be fixed, not sure how long ago though.

I oddly don't recall ever getting notifications about @jbotte's activity on this, I would've responded in if so.

[desrosj]

Thanks, @dougwollison! Closing out.