WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#38196 closed defect (bug) (fixed)

post/output.php tests are leaky

Reported by: boonebgorges Owned by: boonebgorges
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

The $pages global is getting populated in Tests_Post_Output::test_the_content_attribute_value_with_colon(), but not being reset properly.

See #36934.

Change History (2)

#1 @boonebgorges
3 years ago

In 38678:

Tests: Reset post-related globals after each test.

Globals like $pages were leaking between tests, resulting in various
bits of weirdness.

Globals will kill WordPress. Globals are killing WordPress.

See #38196.

#2 @boonebgorges
3 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 38679:

Tests: Move get_the_excerpt() tests to their own file.

See #36934. Fixes #38196.

Note: See TracTickets for help on using tickets.