WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38197


Ignore:
Timestamp:
10/15/2016 05:13:39 PM (4 years ago)
Author:
dshanske
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38197

    • Property Summary changed from Deprecate and Replace Pingback() Function to Update Pingback function To Add Return
  • Ticket #38197 – Description

    initial v1  
    1 Related to #36824. 
     1Related to #36824.
    22
    3 The current pingback function accepts two parameters...content and $post_ID. Suggesting a new function, perhaps send_ping( $post_ID|$post ) which retrieves the post object instead and gets the content from that.
     3Updated to reflect focus on the return issue.
    44
    5 The current function having to pass the content doesn't make sense. In #36824, the proposal was to improve performance of the do_all_pings function.
     5In #36824, the proposal was to improve performance of the do_all_pings function. Part of this involves the fact that if a pending trackback URL is sent a pingback successfully, it should not also send a trackback.
    66
    7 The new function should also optionally return true or a WP_Error object in the event the sending fails, for debugging purposes.
     7The function should also optionally return which URLs were successfully pinged or a WP_Error object in the event the sending fails, etc.
     8
     9This would change the signature of the function but would allow for debugging, response to errors, as well as assist in optimizing the do_all_pings function.
     10
     11The original proposal was to deprecate pingback because it includes $content, a parameter better retrieved from the post itself for purposes of integrity. However, that can be addressed in other ways.