Make WordPress Core

Opened 8 years ago

Closed 4 years ago

#38200 closed enhancement (duplicate)

Store a `comment_type` for all Comments, not just custom comment types

Reported by: rachelbaker's profile rachelbaker Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: needs-patch comment-type
Focuses: rest-api Cc:

Description

Currently the comment_type column for the comments table only stores a value (like trackback or pingback) when an irregular comment object is added. Standard comments are stored with a comment_type of ''.

SELECT * FROM `wp_comments` WHERE `comment_type` = ' ';

This isn't very intuitive, and does not follow the expectations set by the post_type column in the posts table.

Changing to storing a comment_type value for all comments is also pre-requisite for supporting custom comment types (see #35214).

This change will require an upgrade routine as well as some back-compat work.

Change History (6)

#1 @bordoni
8 years ago

Would we store the value as comment? To follow the structure done by post_type been post.

#2 @rachelbaker
8 years ago

  • Keywords REST-API added

#3 @rachelbaker
8 years ago

  • Keywords comment-type added

Related #31072

#4 @ocean90
8 years ago

  • Focuses rest-api added
  • Keywords REST-API removed

#5 @desrosj
6 years ago

  • Milestone changed from Awaiting Review to Future Release

#6 @TimothyBlynJacobs
4 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

This has been fixed by #49236.

Note: See TracTickets for help on using tickets.