Allow post object or post id for ping functions

[dshanske]

Suggesting the following functions be updated to accept either a post_ID or a post object

get_pung( int $post_id )
get_to_ping( int $post_id )
do_trackbacks( int $post_id )

[dshanske]

Add Post Object support to Ping Functions

[swissspidy]

Patch looks good, sounds like a great opportunity to add some unit tests though.

[pento]

The @since comment on do_trackbacks() is incomplete.

What's the purpose of making this change?

[dshanske]

To support optimization of do_all_pings

[swissspidy]

Replying to pento:

What's the purpose of making this change?

Most functions in core support poth post objects and IDs nowdays. I especially like that we can get rid of $wpdb in get_to_ping() that way.

[dshanske]

I could use some help with the unit tests. It's something I'm still struggling to learn how to write.

[dshanske]

Adds some unit tests

[dshanske]

Added unit tests for the changes to get_to_ping, get_pung, add_ping.

Not sure how to test trackback and pingback sending. I think that is out of scope for this.

[rachelbaker]

@dshanske the functions still accept a post_id, so let's keep the parameter name as $post_id.

[dshanske]

Happy to make the change. I thought changing the parameter name to post made it more consistent with other functions that work similarly. But it isn't an issue either way.

[dshanske]

In pingack it is post_ID, in the others post_id. In the interest of consistency, I changed all of them to post_id.

[dshanske]

Fixes

[pento]

In 38852:

Pings: Allow ping functions to accept WP_Post objects as well as post IDs.

This removes the use of several global $wpdb instances, as well as bringing the ping functions into line with other post-related functions, which will accept a post ID or WP_Post object.

Props dshanke.
Fixes #38202.