Opened 8 years ago
Closed 7 years ago
#38210 closed enhancement (duplicate)
WPMS sites list table doesn't display the blog name by default
Reported by: | Mista-Flo | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Networks and Sites | Keywords: | ux-feedback has-patch close |
Focuses: | multisite | Cc: |
Description
I really don't understand why in WPMS sites list table (wp-admin/network/sites.php) page, the blog name is not displayed by default (only in 'excerpt' mode), instead, the URL of the blog is displayed.
It's really difficult to identify the current blog only with only the URL.
Why don't we display the blog name by default in a new column, next to the URL one ?
Attachments (4)
Change History (15)
#3
@
8 years ago
Thank you for your answer, I guess it's a crucial information for a lot of users, maybe not all yes, but it should be a default behavior in my opinion. Unfortunately, if it's a performance matter, I understand and maybe we have to forget this enhancement.
#4
@
7 years ago
- Keywords has-patch added; needs-patch removed
Hello,
I'm also managing multiple, Multisites across different servers for different purposes and in my opinion it would be really useful to see the names actually. For example in my field usually the sites url is just an automated code but the Name is actually the clients name so it would make perfect sense to have it all the time there.
Also the switch_to_blog is either way used in here for the Excerpt view so I don't feel like it is going to make that much of a performance issue.
I've uploaded a small patch ( 38210.diff )as it was an easy fix to implement a name in there and I also removed it from the Excerpt view to not have duplicates.
Check it out and you might like it better... I do at least and probably going to implement it right away on my deployments to check it out as well.
Best regards,
Konstantinos
This ticket was mentioned in Slack in #core by xkon. View the logs.
7 years ago
#6
@
7 years ago
- Component changed from Administration to Networks and Sites
- Milestone changed from Awaiting Review to 4.9
38210.diff seems like a good first step.
- Could we get both
blogname
andblogdescription
in a singleswitch_to_blog()
call? - Once
blogname
is moved above the URL, theprintf()
and__()
calls forblogdescription
can be removed, it doesn't make much sense to translate__( '%1$s' )
on its own.
#7
@
7 years ago
Following @SergeyBiryukov suggestion which makes total sense I remade the code to 38210.2.diff .
If it can get even better please advice so I can proceed with updates.
Best regards,
Konstantinos
#8
follow-up:
↓ 9
@
7 years ago
While it's nice that the code did not use switch_to_blog()
before, I think the benefits here outweigh the cost. However, we must consider that this will decrease performance a bit (which is probably okay, considering we're doing that in so many places already).
#9
in reply to:
↑ 8
@
7 years ago
Hello @flixos90 what do you mean? It was using it in the excerpt view. It just got transferred outside the views to gain access either way .
To complete the thinking behind this of why this is basically 'faster' not code-wise but usability wise is this.
Like I mentioned it was used on the Excerpt view either way that it was loading the name + description as well.
Imagine having a bloated list of sites but by random paths ( like the ones I'm used to in the company I work for... don't ask me why they just do it ). This means i have to wait 1 time for the page to load then click the Excerpt to view the clients name and eh, wait again even a bit longer. That's double time for me. So by just moving it out you might wait longer first hand but you might never use the Excerpt view again as well as the main interest would be the blog's name usually not the description as much.
Just a thought.
Best regards,
Konstantinos
Replying to flixos90:
While it's nice that the code did not use
switch_to_blog()
before,).
#10
@
7 years ago
- Keywords close added
On a second closer look, I don't think that change is necessary.
I like the idea of keeping the list
mode free of switch_to_blog()
calls. This allows everyone to choose between the variant they like: more performance vs. more information.
As stated by @ocean90 before, not everyone cares about the names of each site. Those who do can already see that information via the excerpt
view.
@SergeyBiryukov I'm curious what you think about this, but I'd suggest closing this as I don't see a benefit by having the two modes showing the same amount of information, particularly since that means decreasing the performance of one variant.
I'm managing a network with sites in 150 languages, since I don't speak all of them the name is really unimportant to me.
The main reason is probably that displaying the name and description requires a
switch_to_blog()
call which isn't quite performant.