Opened 8 years ago
Closed 8 years ago
#38222 closed defect (bug) (fixed)
Customize themes section doesn't show theme screenshots, border hover issues
Reported by: | celloexpressions | Owned by: | celloexpressions |
---|---|---|---|
Milestone: | 4.7 | Priority: | high |
Severity: | normal | Version: | 4.7 |
Component: | Customize | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description
There are some odd visual regressions in the themes section in trunk. This'll be replaced in #37661, but this ticket is to track those in case that project doesn't make it into 4.7. See https://wordpress.slack.com/archives/core-customize/p1475517778001564.
Attachments (3)
Change History (14)
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
8 years ago
This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.
8 years ago
#4
@
8 years ago
- Milestone 4.7 deleted
- Resolution set to invalid
- Status changed from assigned to closed
#5
@
8 years ago
- Keywords needs-patch added
- Milestone set to 4.7
- Priority changed from low to high
- Resolution invalid deleted
- Status changed from closed to reopened
Needs a patch because of [39140].
This ticket was mentioned in Slack in #core-customize by mckernanin. View the logs.
8 years ago
#7
@
8 years ago
I did some digging into the missing screenshots.
It appears that renderScreenshots() is no longer being called on opening the panel. In 4.6.1, this was done in onChangeExpanded(), line 977. renderScreenshots() is still bound to the filter field, if you type something into the theme search box then all of the screenshots will load.
I'm not sure where this should be hooked back in, but I'm happy to assist however I can!
Related to [34391]
#8
@
8 years ago
- Focuses javascript added
- Keywords has-patch added; needs-patch removed
@celloexpressions - Just as @mckernanin noticed, Themes panel's expand routine is missing a call to renderScreenshots()
and scroll
event listener. I've added missing lines and issued a PR:
https://github.com/xwp/wordpress-develop/pull/195
There's also a diff file attached to this ticket.
#9
@
8 years ago
I've completely missed the styling issues in my initial patch. I've just submitted a new patch that fixes both screenshots rendering and CSS issues (the PR is updated as well)
No idea what happened here, but invalidated by [38813].