Opened 10 years ago
Last modified 4 weeks ago
#38224 new defect (bug)
Not enough results in menu-page-add-search
| Reported by: | clearsite | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Menus | Version: | 4.6.1 |
| Severity: | normal | Keywords: | dev-feedback 2nd-opinion has-patch has-unit-tests |
| Cc: | Focuses: |
Description
While editing menu, trying to add a page, searching for the page "research" in a database with hundreds! of pages with this word in it, looking for that ONE page with just 'research' as title, the page is not listed
admin/includes/nav-menu.php, _wp_ajax_menu_quick_search with type=quick-search-posttype-page the WP_Query lists posts_per_page = 10, but the search does NOT provide a paginator.
I call this a bug because it is not working as intended; I assume you intended that the search would allow a page to be found, so the bug would be "pagination is missing"
I have hard-coded a -1 to avoid the issue for now
possible solutions are:
- add pagination
- add a filter on the arguments so we can set a different page-size without altering the code
Attachments (2)
Change History (9)
#2
@
10 years ago
- Keywords has-patch added
Potential patch attached. I'm not sure what the standard tool is to minify the assets so my diff does not include minified files, in saying that, make sure that you define SCRIPT_DEBUG and set it to true in your wp-config.php file.
#4
@
10 years ago
- Keywords needs-patch added; has-patch removed
I would love to see this in 4.8. I will refresh the patch + add tests to look more like this https://core.trac.wordpress.org/ticket/35577 which was released in 4.7.
#5
@
7 months ago
- Keywords 2nd-opinion added; needs-testing removed
Thanks for the report and the earlier patch work here.
With needs-patch added again, removing needs-testing seems reasonable for now since there’s no current patch to test. Adding 2nd-opinion may also help confirm the best approach before new patch work begins.
This ticket was mentioned in PR #12763 on WordPress/wordpress-develop by @sukhendu2002.
6 weeks ago
#6
- Keywords has-patch has-unit-tests added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/38224
## Use of AI Tools
#7
@
4 weeks ago
Thanks for reporting this, @clearsite
I picked up this ticket because the original issue is still reproducible on current trunk: nav menu quick searches remain limited to the first 10 matching items, making results beyond that limit inaccessible on larger sites.
I opened PR #12763 to add bounded pagination for post type and taxonomy searches.
Testing and feedback on the approach are welcome.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
+1 for this issue, I've had to workaround this in the past as well.