WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#38224 new defect (bug)

Not enough results in menu-page-add-search

Reported by: clearsite Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.6.1
Component: Menus Keywords: dev-feedback needs-testing needs-patch
Focuses: Cc:

Description

While editing menu, trying to add a page, searching for the page "research" in a database with hundreds! of pages with this word in it, looking for that ONE page with just 'research' as title, the page is not listed

admin/includes/nav-menu.php, _wp_ajax_menu_quick_search with type=quick-search-posttype-page the WP_Query lists posts_per_page = 10, but the search does NOT provide a paginator.

I call this a bug because it is not working as intended; I assume you intended that the search would allow a page to be found, so the bug would be "pagination is missing"

I have hard-coded a -1 to avoid the issue for now

possible solutions are:

  • add pagination
  • add a filter on the arguments so we can set a different page-size without altering the code

Attachments (2)

patch_38224.diff (6.4 KB) - added by tristangemus 4 years ago.
38224.diff (6.4 KB) - added by tristangemus 4 years ago.
Proper development folder structure, no code changes.

Download all attachments as: .zip

Change History (6)

#1 @tristangemus
4 years ago

+1 for this issue, I've had to workaround this in the past as well.

#2 @tristangemus
4 years ago

  • Keywords has-patch added

Potential patch attached.

Version 0, edited 4 years ago by tristangemus (next)

@tristangemus
4 years ago

Proper development folder structure, no code changes.

#3 @tristangemus
4 years ago

  • Keywords dev-feedback needs-testing added

#4 @tristangemus
3 years ago

  • Keywords needs-patch added; has-patch removed

I would love to see this in 4.8. I will refresh the patch + add tests to look more like this https://core.trac.wordpress.org/ticket/35577 which was released in 4.7.

Note: See TracTickets for help on using tickets.