WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38231, comment 8


Ignore:
Timestamp:
05/26/2021 03:24:29 PM (4 months ago)
Author:
psrpinto
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38231, comment 8

    initial v1  
    1313Changes in [attachment:"38231.2.diff"]:
    1414
    15 - No longer check that `$content_disposition` is not empty before the call to `preg_match()`. If it is empty, it won't match, so that check is unnecessary. (`wp_remote_retrieve_header()` returns either a filename or an empty string).
     15- No longer check that `$content_disposition` is not empty before the call to `preg_match()`. If it is empty, it won't match, so that check is unnecessary. (`wp_remote_retrieve_header()` returns either the header or an empty string).
    1616- Treat Content-Disposition as "progressive enhancement", falling back to original randomly-generated filename in case of error.
    1717- Support the case where the header contains no quotes: `Content-Disposition: filename=foo.txt`