wp_get_users_with_no_role() generates query based on role display names not role name

[szaqal21]

This is a follow-up to #22993.

wp_get_users_with_no_role() doesn't work properly when there is and custom role eg. role name is "admin_www" and display name is "Admin WWW", function generates query:

SELECT user_id FROM wp_usermeta WHERE meta_key = 'wp_capabilities' AND meta_value NOT REGEXP 'Author|Contributor|Subscriber|Redaktor|Administrator|AdminWWW'

query should be build based on role name not display name.

[ocean90]

Thanks for the report, it should indeed use the role name.

[procodewp]

Patch to use role name instead of role display name in wp_get_users_with_no_role()

[procodewp]

Explanation for the patch:

wp_roles()->get_names() returns an array in the format:

role_name => display_role_name

wp_get_users_with_no_role() uses the array value (display name) to build the regex, when it should use the array key (role name).

[choongsavvii]

38234.2.patch contains both @procodewp 's original fix, and the accompanying unit test.

[johnbillion]

In 38787:

Users: Use the role name instead of the role display name when fetching the list of users with no role. This avoids false positives when dealing with user roles that, for example, contain spaces in the display name.

Props procodewp, choongsavvii
Fixes #38234