WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 6 months ago

#38237 closed task (blessed) (wontfix)

Increase the slow test threshold for tests that perform external HTTP requests

Reported by: johnbillion Owned by: johnbillion
Milestone: Priority: normal
Severity: normal Version: 4.4
Component: Build/Test Tools Keywords: needs-patch good-first-bug
Focuses: Cc:

Description

Tests that perform external HTTP requests will always trigger a slow warning from SpeedTrapListener as core's slow test threshold is set to 150ms.

Let's add a @slowThreshold header to each relevant test with a high value such as 5000ms.

Docs: https://github.com/johnkary/phpunit-speedtrap

See #30017.

Change History (6)

#1 @johnbillion
5 years ago

In 38757:

HTTP API: Convert the POST redirect test to use a dataProvider in order for its speed to be more accurately measured.

See #38237

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


5 years ago

#3 @jbpaul17
5 years ago

  • Owner set to johnbillion
  • Status changed from new to assigned

#4 @johnbillion
5 years ago

  • Keywords ongoing added
  • Milestone changed from 4.7 to Future Release
  • Type changed from defect (bug) to task (blessed)

#5 @johnbillion
16 months ago

  • Keywords needs-patch good-first-bug added; ongoing removed

#6 @johnbillion
6 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

After some discussion with Tonya, Juliette, Sergey, and myself, we've decided to remove SpeedTrapListener completely for a few reasons:

  • Maintaining compatibility with future versions of PHPUnit becomes more complicated as the listener API changes, particularly with the upcoming support for PHPUnit 8
  • The listener has seen little use by anybody - the external HTTP request tests have been running tests longer than the allowed threshold since the day it was introduced
  • SpeedTrapListener can still be added as a dependency locally and used when performance investigation is required, it doesn't need to be in core

The removal will be handled in #46149

Note: See TracTickets for help on using tickets.