Opened 8 years ago
Closed 8 years ago
#38246 closed defect (bug) (invalid)
Ensure that the first populated network is a `WP_Network`
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | Networks and Sites | Keywords: | has-patch |
| Focuses: | multisite | Cc: |
Description
When the function populate_network() is called on upgrade from single to multisite, the $current_site global is written as a plain object. Since we have WP_Network now, we should ensure it is an instance of that class.
As a site-effect, the number of operations where the global is accessed is reduced so that we can easier replace this by a better mechanism at some point. :)
Attachments (1)
Change History (4)
#1
@
8 years ago
- Keywords has-patch added; needs-patch removed
- Owner set to flixos90
- Status changed from new to assigned
This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.
8 years ago
#3
@
8 years ago
- Milestone 4.7 deleted
- Resolution set to invalid
- Status changed from assigned to closed
This was way too rushed - the WP_Network class is not available at this point so we're good with using a plain object here.
While it might make sense to require the multisite-specific function and class files when the network is installed, let's not go down that path just yet as it will need further thought.
Closing this, sorry for the noise. :)
38246.diff fixes this.