Opened 7 years ago
Closed 7 years ago
#38254 closed defect (bug) (fixed)
outdated blog post in register_meta doc for 4.6 update
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | 4.6 |
Component: | Options, Meta APIs | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
Hello,
The 4.6 WordPress version update the register_meta function, in the PHP Doc header of the function, there is a link to the Core blog post that explains changes, but it's an outdated post, since the direction of the function change's has evolved.
Now it should be https://make.wordpress.org/core/2016/07/20/additional-register_meta-changes-in-4-6/ instead of https://make.wordpress.org/core/2016/07/08/enhancing-register_meta-in-4-6/
Attachments (3)
Change History (14)
This ticket was mentioned in Slack in #docs by florian-tiar. View the logs.
7 years ago
#4
@
7 years ago
- Keywords close added
IIRC this was intentionally because the second post doesn't include all the information which the initial post has.
#5
@
7 years ago
- Keywords close removed
My patch 38254.diff has the same changes as the one from @Mista-Flo, just from outside src
. His patch wasn't applying with grunt patch
so I tried with the same info and uploaded it from grunt to test it out.
#6
@
7 years ago
@ocean90 The note at the top of the original post directs readers to use the second one. Maybe it would be better to include the notes from those posts in the inline docs with the correct usage instead of just linking to one or the other?
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
7 years ago
#8
@
7 years ago
- Keywords commit removed
- Milestone changed from 4.7 to Awaiting Review
I don't think we should change the posts. Maybe there should be a page on devhub instead. I'm leaving the decision to @DrewAPicture.
#9
@
7 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from Awaiting Review to 4.7
I think the best move here would be to link to the ticket (#35658) as the canonical history for the changes introduced in 4.6. All of the discussions, decision making, and conclusions are included there.
Fix phpdoc