Context Navigation

← Previous Ticket
Next Ticket →

#38256 closed enhancement (maybelater)

Make use of PHPUnit's @requires notation

Reported by:	johnbillion	Owned by:	johnbillion
Priority:	low	Milestone:
Component:	Build/Test Tools	Version:
Severity:	normal	Keywords:
Cc:		Focuses:

Description

Several unit tests include logic to skip the test if certain extensions or functions aren't available. PHPUnit has native support for this functionality in the form of @requires headers, so it may as well be used.

Docs: https://phpunit.de/manual/current/en/incomplete-and-skipped-tests.html#incomplete-and-skipped-tests.skipping-tests-using-requires

Change History (5)

#1 @johnbillion
10 years ago

Owner set to johnbillion
Resolution → fixed
Status new → closed

In 38759:

Build/Test Tools: Make use of PHPUnit's @requires notation.

Fixes #38256

#2 @swissspidy
10 years ago

IIRC there are also a few tests requiring the xdebug extension. Also, what about the image editor tests?

#3 @swissspidy
10 years ago

Resolution fixed
Status closed → reopened

Looks like it causes a couple of test failures on PHP 5.2, see https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/165976994#L387

#4 @johnbillion
10 years ago

Resolution → fixed
Status reopened → closed

In 38761:

Build/Test Tools: Revert [38759]. PHPUnit's @requires syntax was introduced in PHPUnit 3.7, but the tests for PHP 5.2 use PHPUnit 3.6 because it's the latest version that supports PHP 5.2.

Fixes #38256

Last edited 10 years ago by johnbillion (previous) (diff)

#5 @johnbillion
10 years ago

Milestone 4.7
Resolution fixed → maybelater

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#38256 closed enhancement (maybelater)

Make use of PHPUnit's @requires notation

Description

Change History (5)

#1 @johnbillion 10 years ago

#2 @swissspidy 10 years ago

#3 @swissspidy 10 years ago

#4 @johnbillion 10 years ago

#5 @johnbillion 10 years ago