Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #38266, comment 19


Ignore:
Timestamp:
09/07/2020 12:05:10 AM (5 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38266, comment 19

    v1 v2  
    33The remaining instances fall into three groups:
    44
    5 * Ones that use delta comparison for floats, dates, etc. These should be switched to [https://github.com/sebastianbergmann/phpunit/blob/7.5.0/ChangeLog-7.5.md#added assertEqualsWithDelta()] once PHPUnit 7.5 is the minimum supported version.
     5* Ones that use delta comparison for floats, dates, etc. These should be switched to [https://github.com/sebastianbergmann/phpunit/blob/7.5.0/ChangeLog-7.5.md#added assertEqualsWithDelta()] once PHPUnit 7.5 is the minimum supported version. Or, perhaps `assertEqualsWithDelta()` should be polyfilled for older PHPUnit versions.
    66* Ones that legitimately use `assertEquals()` for comparing objects. Trying to switch these to `assertSame()` would result in "Failed asserting that two variables reference the same object" error.
    77* Ones that should be switched to `assertSame()`, but would currently result in a failure when doing so, due to data type mismatches, mostly strings vs. integers, or integers vs. floats. These need further investigation: