WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38280, comment 24


Ignore:
Timestamp:
07/05/2018 04:01:36 PM (2 years ago)
Author:
desrosj
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38280, comment 24

    initial v1  
    2222When a taxonomy is registered, no object type validation is performed. So, you could register a `foo` object type for a taxonomy even if `foo` objects are not registered. Maybe `1 >= count( $taxonomy_object->object_type )` could be changed to count the number of object types that currently exist instead. This would add a need to compare the number of object types stored in `_wp_counted_object_types` with the number of active in order to trigger recounting if an object type is removed, but could prevent inaccurate counts when an object type is removed.
    2323
    24 I also created [https://travis-ci.org/desrosj/wordpress-develop/builds/400503713 a branch on my WordPress Develop fork] to show the tests passing. This branch reflects [attachment:"38280.16.diff"].
     24I also created [https://travis-ci.org/desrosj/wordpress-develop/builds/400506301 a branch on my WordPress Develop fork] to show the tests passing. This branch reflects [attachment:"38280.16.diff"].
     25
     26Edit: Changed Travis build link to correct passing build.