Remove $sep variable duplication from Ternary Operator

[joelcj91]

In WP_List_Table class, we are using ternary operators a lot. We know that the main advantage of the ternary operator is, it makes code shorter.

Instead of uisng ternary operator like this,

( $i == $action_count ) ? $sep = '' : $sep = ' | ';

Can we use,

$sep = ( $i == $action_count ) ? '' : ' | ';

So the variable $sep is written once. Shortening the code a bit.

[joelcj91]

Patch to remove variable duplication

[desrosj]

Thanks for this, @joelcj91! Sorry that it took so long to receive a response.

This is a good suggestion, IMO. Are you able to refresh the patch to apply cleanly to trunk?

[joelcj91]

Patch refresh

[joelcj91]

Thanks, @desrosj. I have updated the patch after updating the trunk.

[audrasjb]

Closing this ticket as fixed since it looks like it was previously fixed in another one.
Now the related code is:
$sep = ( $i < $action_count ) ? ' | ' : '';

[audrasjb]

Hmm. Reopening this ticket as it appears that the issue wasn't fixed for every files.
Patch incoming.

[audrasjb]

Coding standards: Fix an inconsistency in the usage of ternary operators for the $sep variable/

[audrasjb]

Moving this minor patch for 5.9 consideration.

[SergeyBiryukov]

In 51873:

Coding Standards: Remove duplicate assignment from a ternary operator in WP_MS_Sites_List_Table::site_states().

Adjust similar code in _post_states() and _media_states() for consistency.

Follow-up to:

• [12897], [15491], [32755], [46153], [48424] for WP_MS_Sites_List_Table::site_states().
• [17793], [47775], [49223] for _media_states().
• [9153], [46309] for _post_states().

Props joelcj91, audrasjb, desrosj.
Fixes #38296.