WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 6 months ago

#38311 closed defect (bug) (invalid)

Remove undefined variable `$port` in src/wp-admin/includes/class-ftp-sockets.php:141

Reported by: miyauchi Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.5
Component: External Libraries Keywords:
Focuses: Cc:

Description

$port is undefined in this function.

Attachments (1)

38311.patch (661 bytes) - added by miyauchi 3 years ago.

Download all attachments as: .zip

Change History (7)

@miyauchi
3 years ago

#1 @dd32
3 years ago

  • Component changed from General to External Libraries

Hi @miyauchi!

Does this cause a PHP Notice or similar for you, or was it discovered through a static analysis application or similar?

The reason I ask, is that although the variable is unused, it doesn't appear to cause any problems as it's a return by-ref variable, and part of an external library.

#2 @miyauchi
3 years ago

OK, thanks! :)

#3 @desrosj
6 months ago

  • Keywords reporter-feedback close added

@miyauchi Are you able to clarify if you were seeing a PHP notice?

Marking this as close pending the answer to that question. Since this is an older external library that has not been updated in some time, I think we should only fix this if a notice is triggered.

#4 @desrosj
6 months ago

  • Version set to 2.5

#5 @miyauchi
6 months ago

@desrosj

Actually, I don't remember how I found this issue. :)
And I am ok to close this ticket now.

Thanks!

#6 @desrosj
6 months ago

  • Keywords reporter-feedback close removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.