Remove undefined variable `$port` in src/wp-admin/includes/class-ftp-sockets.php:141

[miyauchi]

$port is undefined in this function.

[dd32]

Hi @miyauchi!

Does this cause a PHP Notice or similar for you, or was it discovered through a static analysis application or similar?

The reason I ask, is that although the variable is unused, it doesn't appear to cause any problems as it's a return by-ref variable, and part of an external library.

[miyauchi]

OK, thanks! :)

[desrosj]

@miyauchi Are you able to clarify if you were seeing a PHP notice?

Marking this as close pending the answer to that question. Since this is an older external library that has not been updated in some time, I think we should only fix this if a notice is triggered.

[miyauchi]

@desrosj

Actually, I don't remember how I found this issue. :)
And I am ok to close this ticket now.

Thanks!