Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 months ago

#38320 closed enhancement (fixed)

Add $network_id parameter to hooks in `add_network_option()`

Reported by: flixos90 Owned by: jeremyfelt
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Options, Meta APIs Keywords: has-patch has-dev-note
Focuses: multisite Cc:


The actions and filters in add_network_option() do not receive the network ID passed to the function which makes using them worthless for several use-cases. The parameter should be added.

Attachments (1)

38320.diff (2.1 KB) - added by flixos90 4 years ago.

Download all attachments as: .zip

Change History (5)

4 years ago

#1 @flixos90
4 years ago

  • Keywords has-patch added; needs-patch removed

38320.diff introduces the $network_id parameter to the hooks in add_network_option().

#2 @jeremyfelt
4 years ago

  • Milestone changed from Awaiting Review to 4.7
  • Owner set to jeremyfelt
  • Status changed from new to reviewing

Looks good, thanks @flixos90.

Related #38319, #38321, #38322.

#3 @jeremyfelt
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 38816:

Multisite: Add $network_id parameter to hooks in add_network_option().

Props flixos90.
Fixes #38320.

#4 @desrosj
4 months ago

  • Keywords has-dev-note added

Linking the dev note that was published here for reference: https://make.wordpress.org/core/2016/11/04/multisite-focused-changes-in-4-7/

Note: See TracTickets for help on using tickets.