WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#38328 closed enhancement (fixed)

Lost Password email construction - two links should be one.

Reported by: code-monkey Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.7
Component: Login and Registration Keywords: has-patch
Focuses: Cc:

Description

The generic lost password email is poorly constructed. It states "...password be reset for the following account" and then echoes the home URL of the Wordpress site, leading many users unfamiliar with Wordpress to click this link rather than the more cryptic-looking longer (correct!) password-reset link.

Surely the 'account' should just state the 'Site name' with no link to the home_url. Or if it's important to give the home_url, why not clearly separate the two different links:

Account homepage: {network_home_url}
Reset your password: {network_site_url("wp-login.php?action=rp&key=$key&login="}

Attachments (3)

Screen Shot 2016-10-17 at 1.46.24 pm.png (95.4 KB) - added by dd32 4 years ago.
Example of the existing email
38328.diff (676 bytes) - added by Presskopp 4 years ago.
38328.2.diff (688 bytes) - added by Presskopp 3 years ago.

Download all attachments as: .zip

Change History (10)

@dd32
4 years ago

Example of the existing email

@Presskopp
4 years ago

#1 @Presskopp
4 years ago

  • Keywords has-patch added

Patch introducing "Site name" instead of link.

#2 @lukecavanagh
4 years ago

@Presskopp

Patch applies cleanly. The change works well.

#3 @Presskopp
4 years ago

If we ever decide to use this, we can talk about capitalizing the "name", corresponding to

https://core.trac.wordpress.org/browser/trunk/src/wp-signup.php?marks=106#L106

This ticket was mentioned in Slack in #core by presskopp. View the logs.


3 years ago

#5 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 4.9

@Presskopp
3 years ago

#6 @Presskopp
3 years ago

'refreshed' patch variant with "Site Name" instead of "Site name"

#7 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41578:

Login and Registration: Replace home URL in password reset email with the site name to avoid confusing the user with multiple links.

Props Presskopp, code-monkey.
Fixes #38328.

Note: See TracTickets for help on using tickets.