WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#38337 closed defect (bug) (fixed)

Unit Tests and fix for _canonical_charset() function

Reported by: pbearne Owned by: pento
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: Charset Keywords: has-patch has-unit-tests
Focuses: Cc:
PR Number:

Description

Just the unit tests and a small fix / tidy to handle mixed case strings

Before the fix the string Utf-8 and Iso8859-1 returned incorrect values

Attachments (1)

canonical-charset.patch​ (2.6 KB) - added by pbearne 3 years ago.
patch with unit tests

Download all attachments as: .zip

Change History (5)

@pbearne
3 years ago

patch with unit tests

#1 @pbearne
3 years ago

  • Keywords has-patch dev-feedback has-unit-tests added

#2 @pento
3 years ago

  • Owner set to pento
  • Status changed from new to reviewing

#3 @pento
3 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 4.7

#4 @pento
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 38809:

Charset: Allow _canonical_charset() to handle mixed-case strings.

Add improved unit tests, and collect existing unit tests together.

Props pbearne.
Fixes #38337.

Note: See TracTickets for help on using tickets.