Hide 'Empty Trash' button when trash is already empty

[swissspidy]

Noticed while working on #37407.

Here's a screenshot:

[swissspidy]

Note that you'll typically only see this right after emptying the trash. When the trash is already empty, there's not even a link to the trash.

[ivantedja]

Patch attached :)
It covers:

• posts
• pages
• comments

I notice something, the code has "Empty Trash" button in "media" as well
But media always deleted permanently so "Empty Trash" for media is never shown up
Is it legacy code?

[lukecavanagh]

@ivantedja

Patch applies cleanly,

[afercia]

Replying to ivantedja:

But media always deleted permanently so "Empty Trash" for media is never shown up

There's a constant define( 'MEDIA_TRASH', true ) to enable trash for media.

[ivantedja]

Thanks @afercia ! Previously I only saw this info: ​https://en.support.wordpress.com/trash/#permanently-deleting-an-upload hence I thought there is no way to delete non-permanently

@lukecavanagh attached additional patch for "media"

[swissspidy]

@ivantedja Thanks! Would you mind combining these two patches into 1? Makes it easier to test.

[ivantedja]

@swissspidy sure, has been attached :)

[Presskopp]

Patch applies cleanly, screenshots attached, patch refreshed

[lukecavanagh]

Patch still applies cleanly and resolves the issue.

[printsachen1]

The patch 38341.2.diff​ did not apply cleanly because it was not created from the project root directory. 38341.3.diff​ fixes this.

One other thing I noticed is that when restoring the last comment in the comments trash, the button remains since the page is not reloaded. This is only a minor issue, but may be something to consider.

[swissspidy]

Thanks @printsachen1 and good catch with the restore! I think it should be easy to make it work in that scenario, provided that the JS isn't that big of a mess.

[Jaydeep Rami]

Attached patch from root

[mathieuhays]

I've just sent a new diff which hides the Empty Trash button for the use case mentioned by @printsachen1.

When testing I also noticed that when the Pages' trash is empty, there quite a lot of spacing due to the fact that there no button or filter anymore. Is it something that should fixed or is it expected to remain like that? Can be seen on the screenshot posted by @Presskopp.

[mathieuhays]

add php-unit test

[mathieuhays]

I just pushed a new diff adding a simple PHP-Unit test.

[cazm]

Fixing missing button when Spam is deleted and no trash

[cazm]

In certain conditions, when an item of Spam was "deleted perminently" and Trash = 0, the "empty spam" button disappeared, even when there was more than one item of spam still in the list.

[swissspidy]

One other thing I noticed is that when restoring the last comment in the comments trash, the button remains since the page is not reloaded. This is only a minor issue, but may be something to consider.

Good catch. I think it makes sense to address this in a new ticket.

[swissspidy]

Adds another test for the comments list table

[swissspidy]

In 40297:

List Tables: Hide 'Empty Trash' and 'Empty Spam' buttons when view is already empty.

Props ivantedja, Presskopp, printsachen1, Jaydeep Rami, mathieuhays, cazm.
Fixes #38341.