WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#38344 closed enhancement (fixed)

"Site Language" label for per-user language selection isn't accurate on Multisite

Reported by: johnbillion Owned by: swissspidy
Milestone: 4.7 Priority: normal
Severity: normal Version: 4.7
Component: I18N Keywords: has-ux-feedback has-patch commit
Focuses: multisite Cc:

Description

The new "Site Language" setting on the user profile screen (#29783) actually applies to the whole network (not just the current site) when using Multisite.

Switching this label to "Network Language" isn't ideal, but switching it to just "Language" might be an improvement.

Thoughts?

Attachments (3)

38344.patch (522 bytes) - added by johnbillion 3 years ago.
38344.diff (1.7 KB) - added by jorbin 3 years ago.
38344.2.diff (1.7 KB) - added by swissspidy 3 years ago.

Download all attachments as: .zip

Change History (11)

#1 @swissspidy
3 years ago

Whatever it is we end up with, some explanation in the help tab could be useful here.

#2 @karmatosed
3 years ago

  • Keywords has-ux-feedback added; ux-feedback removed

+1 for 'Language' as that makes more sense.

#3 @jorbin
3 years ago

  • Owner set to swissspidy
  • Status changed from new to assigned

I would either say "Language" or "Your Langauge"

#4 @johnbillion
3 years ago

  • Keywords needs-patch added; 2nd-opinion removed

@johnbillion
3 years ago

#5 @johnbillion
3 years ago

  • Keywords has-patch added; needs-patch removed

38344.patch should be sufficient for communicting this label to translators, I think.

@jorbin
3 years ago

#6 @jorbin
3 years ago

Patch updated to also add new help tab information.

@swissspidy
3 years ago

#7 @swissspidy
3 years ago

  • Keywords commit added

Looks good. Only made a minor wording change in 38344.2.diff

#8 @swissspidy
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38856:

I18N: Improve "Site Language" label for per-user language selection.

Renames the label to "Language" and adds an explanation of the feature to the help tab.

Props johnbillion, jorbin.
Fixes #38344.

Note: See TracTickets for help on using tickets.