WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#38348 closed enhancement (fixed)

Replace get_blog_details() usage in wp-admin/my-sites.php with get_site()

Reported by: flixos90 Owned by: jeremyfelt
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:

Description

See #37102

Attachments (1)

38348.diff (606 bytes) - added by iamfriendly 5 years ago.
Replaced get_blog_details() with get_site() in wp-admin/my-sites.php

Download all attachments as: .zip

Change History (4)

@iamfriendly
5 years ago

Replaced get_blog_details() with get_site() in wp-admin/my-sites.php

#1 @iamfriendly
5 years ago

  • Keywords has-patch added; needs-patch removed

In 38348.diff Replaced get_blog_details() with get_site() in wp-admin/my-sites.php

#2 @jeremyfelt
5 years ago

  • Milestone changed from Awaiting Review to 4.7
  • Owner set to jeremyfelt
  • Status changed from new to reviewing

$site_id is added as a global in ms-settings.php (unfortunately), so I'm a little wary of reassigning it here just for the purpose of calling get_site() just in case someone is relying it.

Let's stick to the existing format and pass (int) $_POST['primary_blog']; directly to get_site().

#3 @jeremyfelt
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 38823:

Multisite: Replace get_blog_details() in wp-admin/my-sites.php with get_site().

Props spacedmonkey, iamfriendly.
See #37102.
Fixes #38348.

Note: See TracTickets for help on using tickets.