WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#38350 closed enhancement (fixed)

Replace get_blog_details() usage in wp_xmlrpc_server::_multisite_getUsersBlogs() with get_site()

Reported by: flixos90 Owned by: jeremyfelt
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: XML-RPC Keywords: has-patch
Focuses: multisite Cc:

Description

See #37102

Attachments (1)

38350.diff (513 bytes) - added by flixos90 4 years ago.

Download all attachments as: .zip

Change History (6)

#1 @flixos90
4 years ago

  • Keywords needs-unit-tests added

It looks like we don't have unit tests for XMLRPC multisite stuff. We should add some together with this change.

This ticket was mentioned in Slack in #core-multisite by richardtape. View the logs.


4 years ago

@flixos90
4 years ago

#3 follow-up: @flixos90
4 years ago

  • Keywords has-patch added; needs-patch needs-unit-tests removed
  • Milestone changed from Awaiting Review to 4.7
  • Owner set to jeremyfelt
  • Status changed from new to reviewing

38350.diff replaces the occurrence of get_blog_details() with get_site().

I think we should skip tests for XMLRPC here since it's not really possible to test the method at this point, especially since it's protected.

#4 in reply to: ↑ 3 @jeremyfelt
4 years ago

Replying to flixos90:

I think we should skip tests for XMLRPC here since it's not really possible to test the method at this point, especially since it's protected.

Agreed. I spent some time looking at this as well and the pain is not really worth the effort.

#5 @jeremyfelt
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 38934:

Multisite: Replace get_blog_details() in wp_xmlrpc_server::_multisite_getUsersBlogs().

Use get_site() instead.

Props flixos90.
Fixes #38350.

Note: See TracTickets for help on using tickets.