WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#38376 closed defect (bug) (fixed)

Ignore third-party scripts in twentyseventeen

Reported by: kadamwhite Owned by: pento
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

Fixes JSHint failures in twentyseventeen third-party scripts

Attachments (1)

38376.diff (489 bytes) - added by kadamwhite 5 years ago.
Gruntfile changes to suppress JSHint errors for third-party theme code

Download all attachments as: .zip

Change History (3)

@kadamwhite
5 years ago

Gruntfile changes to suppress JSHint errors for third-party theme code

#1 @pento
5 years ago

  • Milestone changed from Awaiting Review to 4.7
  • Owner set to pento
  • Status changed from new to assigned

#2 @pento
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 38836:

Build: Ignore JSHint errors in Twenty Seventeen's third party libraries.

html5.js and jquery.scrollTo.js are external libraries, so don't need to be checked by JSHint.

Props kadamwhite.
Fixes #38376.

Note: See TracTickets for help on using tickets.