Twenty Seventeen: Incorrect use of `_x()` in `twentyseventeen_posted_on()`

[ocean90]

​https://github.com/WordPress/twentyseventeen/blob/5b5e4e86c2b8343863d7633758987da93c2bf2e8/inc/template-tags.php#L20

_x() is used to differ two similar strings with different meanings. Translators comments are used to describe placeholders.

Same for twentyseventeen_time_link(), see ​https://github.com/WordPress/twentyseventeen/blob/a15f8d1ed4003007b8e25330dc787cda7b7a32f7/inc/template-tags.php#L48.

[dineshc]

I have attached diff file. Please check the solution for this ticket.

[ocean90]

Thanks for your patch, @dineshc.

The "by %s" string needs a translators comment which explains the placeholder.

The other string should be improved so that the span tag is available for translators: __( '<span class="screen-reader-text">Posted on </span>%s', 'twentyseventeen' )

[mbelchev]

I've added the span tag so it is available for translators and also use sprintf.

[davidakennedy]

Adds translator comments.

[davidakennedy]

38383.4.patch​ builds on the work of @dineshc and @mbelchev and adds the needed translator comments.

[karmatosed]

In 38885:

Twenty Seventeen: Fixes incorrect use of _x()

There is an incorrect use in twentyseventeen_posted_on(). This fixes that.

Props ocean90, dineshc, mbelchev, davidakennedy
Fixes #38383