#38384 closed defect (bug) (fixed)
Twenty Seventeen: Replace inline control structure in `twentyseventeen_content_image_sizes_attr()`
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | good-first-bug has-patch |
Focuses: | Cc: |
Description
To improve code readability the lines 317 and 321 should be changed to a proper if ( ) {} block. Also, per WordPress' coding standards, yoda conditons should only be used for ==, !=, ===, and !==.
Attachments (2)
Change History (9)
#4
@
8 years ago
Sorry, I had missed this. I added the patch from my duplicate ticket. The only difference is that the condition was just added to an existing if for the second replacement.
#5
@
8 years ago
- Owner set to davidakennedy
- Resolution set to fixed
- Status changed from new to closed
In 38847:
#6
@
8 years ago
Should this also be fixed in Twenty Sixteen? See twentysixteen_content_image_sizes_attr().
Note: See
TracTickets for help on using
tickets.
Code readability bug fixed