WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#38388 closed defect (bug) (fixed)

Twenty Seventeen: Page comments need border/spacing

Reported by: melchoyce's profile melchoyce Owned by: davidakennedy's profile davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

https://cloud.githubusercontent.com/assets/2846578/19504545/1d742164-9589-11e6-98b5-1c177d437cb3.png

From ​https://github.com/WordPress/twentyseventeen/pull/470:

We need to add a border/spacing to pages that have comments:

Attachments (1)

38388.patch​ (1.3 KB) - added by laurelfulford 8 years ago.

Download all attachments as: .zip

Change History (3)

@laurelfulford
8 years ago

#1 @laurelfulford
8 years ago

  • Keywords has-patch added; needs-patch removed

Looks like this was an issue with the two column layout on pages. The one column layout pages had space between the content and comments, as well as posts with no meta/edit link. Should be fixed in the patch!

#2 @davidakennedy
8 years ago

  • Owner set to davidakennedy
  • Resolution set to fixed
  • Status changed from new to closed

In 38866:

Twenty Seventeen: Fix spacing issue on pages with comments

This effected the two column layout on pages. The entry content and comment areas needed to be floated and cleared properly.

Props laurelfulford.

Fixes #38388.

Note: See TracTickets for help on using tickets.