WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#38392 closed defect (bug) (fixed)

Twenty Seventeen: Display 'scroll down' arrow alternative when there is no menu

Reported by: laurelfulford Owned by: karmatosed
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

From a comment by melchoyce https://github.com/WordPress/twentyseventeen/pull/458#issuecomment-254592939:

"I'm wondering if there’s any way we could make the scrollability more obvious, maybe by adding a down arrow over the header image so there’s some indication that you can scroll more. Or not taking up the whole viewport, so a little bit of the page background peeks through at the bottom."

Attachments (4)

38392.patch (2.0 KB) - added by nnaimov 5 years ago.
Move the scroll down button into the header if there is no menu set.
38392.2.patch (2.8 KB) - added by davidakennedy 5 years ago.
Style and spacing adjustments
down-arrow-baseline.png (282.3 KB) - added by melchoyce 5 years ago.
38392.3.patch (2.9 KB) - added by davidakennedy 5 years ago.
Adjust arrow position. See: https://cldup.com/PqdG72MpqT.png

Download all attachments as: .zip

Change History (12)

@nnaimov
5 years ago

Move the scroll down button into the header if there is no menu set.

#1 @davidakennedy
5 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

@davidakennedy
5 years ago

Style and spacing adjustments

#2 @davidakennedy
5 years ago

38392.2.patch builds off the previous patch and adjusts the styling for the color when the skip link is not in the nav. It also tweaks some spacing issues.

@melchoyce Do you want to adjust spacing slightly? @laurelfulford How does this look to you?

@nnaimov Thanks for the patch! In the future, please create patches from the root of your WordPress install. It makes easier for others to apply your patches. :)

#3 @melchoyce
5 years ago

Can someone with the patch applied add some screenshots? :)

Last edited 5 years ago by melchoyce (previous) (diff)

#4 @davidakennedy
5 years ago

Current patch:

https://cldup.com/DYxj2HI2mp.png

Last edited 5 years ago by davidakennedy (previous) (diff)

#5 @melchoyce
5 years ago

What do you think about aligning it to the bottom of the tagline text? See down-arrow-baseline.png.

#6 @davidakennedy
5 years ago

How's this? Lined up with my text editor. :)

https://cldup.com/PqdG72MpqT.png

@davidakennedy
5 years ago

Adjust arrow position. See: https://cldup.com/PqdG72MpqT.png

#7 @melchoyce
5 years ago

Looks good!

#8 @karmatosed
5 years ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 38909:

Twenty Seventeen: Display scroll down arrow when no menu

This improves scrollability without a menu.

Props nnaimov, melchoyce, davidakennedy
Fixes #38392

Note: See TracTickets for help on using tickets.