WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#38402 closed defect (bug) (fixed)

Twenty Seventeen: Featured image missing on front page

Reported by: celloexpressions Owned by: davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

You can set a featured image on the front page, but it isn't displayed anywhere. This is confusing UX and possible "loss" of content when switching an existing site to Twenty Seventeen. The image should still be displayed somewhere on the front end if it's set. It doesn't need to be hugely prominent, but should be there somewhere.

Attachments (2)

38402.patch (2.9 KB) - added by laurelfulford 4 years ago.
38402.2.patch (3.0 KB) - added by davidakennedy 4 years ago.
Iterates on 38402.patch and corrects comment for header class.

Download all attachments as: .zip

Change History (5)

#1 @karmatosed
4 years ago

More in-depth discussion over on the GitHub issue: https://github.com/WordPress/twentyseventeen/issues/289. I've moved the discussion here as part of merge.

@laurelfulford
4 years ago

#2 @laurelfulford
4 years ago

  • Keywords has-patch added; needs-patch removed

Based on the discussion of a solution in GitHub, I added the front page's featured image above the front page content, similar to how it's handled in the other panels.

Also removed code that was setting the front page's featured image as a fallback to the custom header, and updated the conditions that add the has-header-image to remove reference to the front page's featured image.

@davidakennedy
4 years ago

Iterates on 38402.patch and corrects comment for header class.

#3 @davidakennedy
4 years ago

  • Owner set to davidakennedy
  • Resolution set to fixed
  • Status changed from new to closed

In 38868:

Twenty Seventeen: Display featured image on static front page

This improves UX, since an image added will be displayed on front end as opposed to not at all. This fix added the front page's featured image above the front page content, similar to how it's handled in the other panels. Also it removed code that was setting the front page's featured image as a fallback to the custom header, and updated the conditions that add the has-header-image to remove reference to the front page's featured image.

Props laurelfulford.

Fixes #38402.

Note: See TracTickets for help on using tickets.