Context Navigation

← Previous Ticket
Next Ticket →

#38404 closed defect (bug) (fixed)

Twenty Seventeen: Hidden article tags on home page

Reported by:	ElectricFeet	Owned by:	karmatosed
Priority:	normal	Milestone:	4.7
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch needs-testing
Cc:		Focuses:

Description (last modified by karmatosed)

reat theme! Very impressed. Thanks

I'm playing around with it to see its potential and note that when a front-page panel is unused, the resulting html has (for example):

<article id="panel3" class="panel-placeholder panel twentyseventeen-panel twentyseventeen-panel3">
<span class="twentyseventeen-panel-title">Panel 3 Placeholder</span>
with

article.panel-placeholder {
    display: none;
}

.twentyseventeen-front-page.twentyseventeen-customizer #primary article.panel-placeholder {
    border: 0;
}

in the CSS.

Is this correct in terms of best practice? Could the php take care of not outputting this html rather than relying on CSS?

Attachments (3)

38404.diff (1.6 KB ) - added by iv.dimova 10 years ago.: Fix for displaying the placeholder only if customizer is open
38404.2.diff (4.6 KB ) - added by morettigeorgiev 10 years ago.: Hide not active articles with php
38404.3.patch (1.4 KB ) - added by davidakennedy 10 years ago.: Refreshes patch since structure and output has changed. Only output placeholders in customizer preview.