Twenty Seventeen: Hidden article tags on home page

[ElectricFeet]

reat theme! Very impressed. Thanks

I'm playing around with it to see its potential and note that when a front-page panel is unused, the resulting html has (for example):

<article id="panel3" class="panel-placeholder panel twentyseventeen-panel twentyseventeen-panel3">
<span class="twentyseventeen-panel-title">Panel 3 Placeholder</span>
with

article.panel-placeholder {
    display: none;
}

.twentyseventeen-front-page.twentyseventeen-customizer #primary article.panel-placeholder {
    border: 0;
}

in the CSS.

Is this correct in terms of best practice? Could the php take care of not outputting this html rather than relying on CSS?

[karmatosed]

Ticket moved over from GitHub as part of merge. There is more context here: ​https://github.com/WordPress/twentyseventeen/issues/339

[iv.dimova]

Fix for displaying the placeholder only if customizer is open

[morettigeorgiev]

Hide not active articles with php

[melchoyce]

Hi @iv.dimova, please do not close tickets until patches have been committed.

[iv.dimova]

@melchoyce thanks a lot for reopening it, I didn't mean to close at all.

[davidakennedy]

Refreshes patch since structure and output has changed. Only output placeholders in customizer preview.

[karmatosed]

In 38998:

Twenty Seventeen: Hidden article tags on home page fix

This prevents the issue of hidden article tags on home page.

Props ElectricFeet, iv.dimova. morettigeorgiev, davidakennedy
Fixes #38404

M twentyseventeen/inc/template-tags.php
M twentyseventeen/style.css