Twenty Seventeen: Pin icon has variations in position and in size

[karmatosed]

I maybe think it should match the line height over what we have:

Note: title changed as it seems to totally move around now in size and position.

[karmatosed]

Moved as part of merge from GitHub. Discussion relating to this ticket here: ​https://github.com/WordPress/twentyseventeen/issues/386

[metodiew]

Here is my suggestion: reduce the height from 32px to 25px.
This is the result after applying the patch 38407-with-the-patch.png

[mbelchev]

I've edited @metodiew's patch because normally icon size is 24px, not 25px.

[karmatosed]

Thanks for all your work. I just today was testing and discovered the pin has some further unusual behaviour now. I think it's best for me to change the title and make sure that this gets wrapped up all in one.

[mbelchev]

That moving is from media queries. I've added some fixes, also about its position (i saw that this is another ticket #38406).

[davidakennedy]

Thanks for the patch @mbelchev!

Here's a demo of the latest patch:

[davidakennedy]

Size adjustments to match font size and RTL additions.

[davidakennedy]

38407.4.patch​ riffs on the nice work done by @metodiew and @mbelchev and makes some tweaks for sizing and RTL.

[karmatosed]

In 38892:

Twenty Seventeen: Resolves the pin icon having variations

This fixes the pin icon having variations in position and size depending on screen and device.

Props metodiew, mbelchev, davidakennedy
Fixes #38407

[davidakennedy]

#38406 was marked as a duplicate.