WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#38407 closed defect (bug) (fixed)

Twenty Seventeen: Pin icon has variations in position and in size

Reported by: karmatosed Owned by: karmatosed
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description (last modified by karmatosed)

I maybe think it should match the line height over what we have:

https://cloud.githubusercontent.com/assets/253067/19417985/91ff88b2-93b2-11e6-802d-5390b5cf03a8.png

Note: title changed as it seems to totally move around now in size and position.

Attachments (5)

38407.diff (430 bytes) - added by metodiew 2 years ago.
38407-with-the-patch.png (114.3 KB) - added by metodiew 2 years ago.
38407-2.patch (430 bytes) - added by mbelchev 2 years ago.
38407-3.patch (883 bytes) - added by mbelchev 2 years ago.
38407.4.patch (1.3 KB) - added by davidakennedy 2 years ago.
Size adjustments to match font size and RTL additions.

Download all attachments as: .zip

Change History (14)

#1 @karmatosed
3 years ago

Moved as part of merge from GitHub. Discussion relating to this ticket here: https://github.com/WordPress/twentyseventeen/issues/386

@metodiew
2 years ago

#2 @metodiew
2 years ago

  • Keywords has-patch added; needs-patch removed

Here is my suggestion: reduce the height from 32px to 25px.
This is the result after applying the patch 38407-with-the-patch.png

#3 @mbelchev
2 years ago

I've edited @metodiew's patch because normally icon size is 24px, not 25px.

@mbelchev
2 years ago

#4 @karmatosed
2 years ago

  • Description modified (diff)
  • Summary changed from Twenty Seventeen: Potentially make the pin icon for sticky posts smaller to Twenty Seventeen: Pin icon has variations in position and in size

Thanks for all your work. I just today was testing and discovered the pin has some further unusual behaviour now. I think it's best for me to change the title and make sure that this gets wrapped up all in one.

https://cldup.com/CRhgo_YGdL.gif

#5 @mbelchev
2 years ago

That moving is from media queries. I've added some fixes, also about its position (i saw that this is another ticket #38406).

@mbelchev
2 years ago

#6 @davidakennedy
2 years ago

Thanks for the patch @mbelchev!

Here's a demo of the latest patch:

https://cldup.com/6N2Y9TMDfp.gif

@davidakennedy
2 years ago

Size adjustments to match font size and RTL additions.

#7 @davidakennedy
2 years ago

38407.4.patch riffs on the nice work done by @metodiew and @mbelchev and makes some tweaks for sizing and RTL.

#8 @karmatosed
2 years ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 38892:

Twenty Seventeen: Resolves the pin icon having variations

This fixes the pin icon having variations in position and size depending on screen and device.

Props metodiew, mbelchev, davidakennedy
Fixes #38407

#9 @davidakennedy
2 years ago

#38406 was marked as a duplicate.

Note: See TracTickets for help on using tickets.