Context Navigation

← Previous Ticket
Next Ticket →

#38407 closed defect (bug) (fixed)

Twenty Seventeen: Pin icon has variations in position and in size

Reported by:	karmatosed	Owned by:	karmatosed
Priority:	normal	Milestone:	4.7
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description (last modified by karmatosed)

I maybe think it should match the line height over what we have:

Note: title changed as it seems to totally move around now in size and position.

Attachments (5)

38407.diff (430 bytes ) - added by metodiew 10 years ago.
38407-with-the-patch.png (114.3 KB ) - added by metodiew 10 years ago.
38407-2.patch (430 bytes ) - added by mbelchev 10 years ago.
38407-3.patch (883 bytes ) - added by mbelchev 10 years ago.
38407.4.patch (1.3 KB ) - added by davidakennedy 10 years ago.: Size adjustments to match font size and RTL additions.

Download all attachments as: .zip

Change History (14)

#1 @karmatosed
10 years ago

Moved as part of merge from GitHub. Discussion relating to this ticket here: https://github.com/WordPress/twentyseventeen/issues/386

@metodiew
10 years ago

Attachment 38407.diff added

@metodiew
10 years ago

Attachment 38407-with-the-patch.png added

#2 @metodiew
10 years ago

Keywords has-patch added; needs-patch removed

Here is my suggestion: reduce the height from 32px to 25px.
This is the result after applying the patch 38407-with-the-patch.png

#3 @mbelchev
10 years ago

I've edited @metodiew's patch because normally icon size is 24px, not 25px.

@mbelchev
10 years ago

Attachment 38407-2.patch added

#4 @karmatosed
10 years ago

Description modified (diff)
Summary Twenty Seventeen: Potentially make the pin icon for sticky posts smaller → Twenty Seventeen: Pin icon has variations in position and in size

Thanks for all your work. I just today was testing and discovered the pin has some further unusual behaviour now. I think it's best for me to change the title and make sure that this gets wrapped up all in one.