WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#38408 closed defect (bug) (fixed)

Twenty Seventeen: Consider making panel border dashes and notices more WP colors

Reported by: karmatosed Owned by: davidakennedy
Milestone: 4.7 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: Cc:
PR Number:

Description

This also will only need to be looked into if we have the theme based multi-panel, but it's worth considering. Currently we have this for the dashes and labels:

No image "//cloud.githubusercontent.com/assets/253067/19222101/9e38d5c6-8e48-11e6-9b43-eacf790523da.png" attached to (https

I would first like to understand why they are purple, there may be something I'm missing. If there is no set reason, then I'd like to suggest we bring them more into WP and base on those colors.

Attachments (3)

38408.0.diff (2.0 KB) - added by celloexpressions 3 years ago.
Fist pass.
38408.gif (1.2 MB) - added by celloexpressions 3 years ago.
With patch, note that the border aren't actually shown when editing colors.
38408.1.diff (2.5 KB) - added by celloexpressions 3 years ago.
Fix border visibility after header videos.

Download all attachments as: .zip

Change History (10)

#1 @karmatosed
3 years ago

Marked as 'dev-feedback' due to the discussion over on the GitHub ticket: https://github.com/WordPress/twentyseventeen/issues/224. I moved it here as part of merge.

#2 @celloexpressions
3 years ago

I was thinking we'd use #38399 for this; don't want the conversation to become too fragmented but we could discuss here as well.

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


3 years ago

@celloexpressions
3 years ago

Fist pass.

#4 @celloexpressions
3 years ago

  • Keywords has-patch needs-refresh added; dev-feedback removed

38408.0.diff is a first pass to match the visible edit shortcut colors. For some reason the z-index: -1 no longer seems to work here - the border is hidden. Need to fix that but can't change the z-index because the section content needs to be accessible so you can click through links to posts, etc.

#5 @melchoyce
3 years ago

Thanks @celloexpressions. Can you add some screenshots?

@celloexpressions
3 years ago

With patch, note that the border aren't actually shown when editing colors.

@celloexpressions
3 years ago

Fix border visibility after header videos.

#6 @celloexpressions
3 years ago

  • Keywords has-screenshots added; needs-refresh removed

38408.1.diff also fixes the visibility of the borders after the header videos commit. See screencast above, but keep in mind that you won't see then changing while you change your selected color hue, that's just for demo purposes.

#7 @davidakennedy
3 years ago

  • Owner set to davidakennedy
  • Resolution set to fixed
  • Status changed from new to closed

In 38988:

Twenty Seventeen: Make border colors for panels match WordPress UI

Also, fixes the visibility of the borders for panels after the header videos commit.

Props celloexpressions.

Fixes #38408.
See #38172.

Note: See TracTickets for help on using tickets.