New Custom Link menu item has a wrong fallback label

[afercia]

On the menus screen, when adding a Custom Link to a menu and leaving the link text field empty, a default fallback Menu Item label was set:

On the latest versions though, the fallback label is (Pending), with a leading space:

This was broken by [36379] my bad. Haven't looked in depth in the code but I think it could be fixed on the PHP side, I guess there's no need to restore the JS part that was removed in [36379].

[christophherr]

Would a feasible approach be to simply add Menu Item to
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-walker-nav-menu-edit.php#L103?
e.g.:

$title = sprintf( __('%s Menu Item (Pending)'), $item->title );

[Fencer04]

I think having Menu Item (Pending) makes sense. I'm new to this but is there a reason we don't make the text field for Custom Links required?

[thakkarhardik]

As per the suggestion, I have changed the label. Please look over it and let me know if anything more is required.

[backermann1978]

Works fine with my local VVV-setup and fixes the issue (tested on WordCamp EU Contributor Day).

[afercia]

Thanks everyone! I tried to look a bit more in depth into this and there are a few things to consider. Testing with JavaScript support disabled and enabled:

JavaScript disabled:
When adding menu items, an additional string (Pending) gets appended to the item name. Also, a notice "Click Save Menu..." appears at the top:

Looks like this part was never implemented in the JavaScript-based implementation.

JavaScript enabled:
The additional string (Pending) is intentionally not displayed. Also the notice doesn't appear.

To respect the original implementation, the string (Pending) shouldn't be displayed. I'd like to propose to just restore the original behavior: when a custom link text is empty, a default "Menu Item" string is used as fallback.

I've noticed a couple inconsistencies in the PHP part and I'm not sure the Custom Links are fully functional when JavaScript is disabled but seems to me those are pre-existing issues. Considering the Menu page will be refactored soon to use blocks, I'd tend to think the best option is to restore a mechanism to have the fallback to athe"Menu Item" string.

[afercia]

38415.diff​ adds a fallback to Menu Item in the ajax action used for the JS implementation. This should restore the original behavior as detailed above. Some testing would be nice :)

[audrasjb]

Before 38415.diff

[audrasjb]

After 38415.diff - Works fine!

[audrasjb]

@afercia I tested the patch and it looks good on my side (see screenshots above).

[afercia]

In 45727:

Menus: Fix the Custom Links text fallback.

When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".

The changes in [36379] broke this behavior making the fallback text: (Pending), with a leading space.

Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.

Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Fixes #38415.

[audrasjb]

Reopening this so it can be back-ported to the 5.2 branch.
Adding needs-testing since we have to check it's ok to land in 5.2.3.

[audrasjb]

Tested on my side against 5.2.2. The patch looks good to go and works fine but unless I'm mistaken [45727] doesn't look to apply cleanly: ajax-actions.php seems to have some dependancies to previous commits.

[JeffPaul]

@afercia any insight into which commit(s) this may depend upon? If not, then we may be best moving this ticket back to 5.3 to limit risk in 5.2.3.

[SergeyBiryukov]

[45727] cleanly applied to the 5.2 branch for me.

[SergeyBiryukov]

In 45828:

Menus: Fix the Custom Links text fallback.

When adding a Custom Link and leaving the "Link Text" field empty, WordPress used to set a default fallback text: "Menu Item".

The changes in [36379] broke this behavior making the fallback text: (Pending), with a leading space.

Pending major refactoring of the Menus page (which is going to use a block-based user interface) this change just restores the original behavior by adding the fallback text to the related AJAX response.

Props christophherr, Fencer04, thakkarhardik, backermann1978, audrasjb.
Merges [45727] to the 5.2 branch.
Fixes #38415.