WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #38420, comment 8


Ignore:
Timestamp:
11/01/2016 06:51:28 PM (5 years ago)
Author:
jnylen0
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #38420, comment 8

    initial v1  
    33I've kept this change, and also added the `type` parameter for all arguments in the namespace index responses because there is no other way to tell that the `status` parameter accepts a list of values when listing posts (in the item schema exposed by `?context=help`, `status` is just a string).  Note this is a larger change, but I think it is the right thing to do.
    44
    5 I did not add the default enum validation from `38420.4.diff` ("Handle enum arrays") because this is a bit of a special case and it needs custom validation logic anyway.  I'm not sure if we should go ahead and add automatic enum array validation here or not.
     5~~I did not add the default enum validation from `38420.4.diff` ("Handle enum arrays") because this is a bit of a special case and it needs custom validation logic anyway.  I'm not sure if we should go ahead and add automatic enum array validation here or not.~~ ''Edit:'' Scratch that bit, I got mixed up while writing this.  The reason I didn't include the validation logic from the previous patch is that it already works in trunk - see `test_type_array_with_enum` in the latest patch.
    66
    77Since the last patch(es) I've also fixed this change for media handling, added all the tests I could think of, and ran through the logic on a couple of test sites.